Build helper libraries with position-independent code if BUILD_SHARED_LIBS is set.#144
Open
alexrp wants to merge 1 commit intoMatroska-Org:masterfrom
Open
Build helper libraries with position-independent code if BUILD_SHARED_LIBS is set.#144alexrp wants to merge 1 commit intoMatroska-Org:masterfrom
alexrp wants to merge 1 commit intoMatroska-Org:masterfrom
Conversation
robUx4
reviewed
Dec 31, 2024
Comment on lines
+4
to
+6
| if (BUILD_SHARED_LIBS) | ||
| set_property(TARGET "minilzo" PROPERTY POSITION_INDEPENDENT_CODE ON) | ||
| endif() |
Contributor
There was a problem hiding this comment.
This contradicts the previous line where "minilzo" is only compiled as a STATIC library.
Author
There was a problem hiding this comment.
Does it? The idea is to build minilzo as a static library, but still as PIC, because that static library gets incorporated into the matroska2 shared library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this is not done,
cmake .. -DBUILD_SHARED_LIBS=ON && cmake --build .will fail like so:(And so on for each static helper library.)